smartdevicelink / generic_hmi

A sample HMI to use with sdl_core
BSD 3-Clause "New" or "Revised" License
8 stars 27 forks source link

Fix large graphic sizing #506

Closed Jack-Byrne closed 2 years ago

Jack-Byrne commented 2 years ago

Testing Plan

Core Tests

Show graphic in the LARGE_GRAPHIC_ONLY and LARGE_GRAPHIC_WITH_SOFTBUTTONS templates. Ensure sizing of image is contained within its parent div.

Core version / branch / commit hash / module tested against: 8.1 Proxy+Test App name / version / branch / commit hash / module tested against: rpcb-js

Summary

Adds max and min height params to the containing divs of the large graphic class.

CLA

ShobhitAd commented 2 years ago

@JackLivio Seeing a similar issue with the DOUBLE_GRAPHIC_WITH_SOFTBUTTONS template

Screenshot from 2022-03-30 17-46-22


{
    "mainField1": "MAIN1",
    "mainField2": "MAIN2",
    "mainField3": "main3",
    "mainField4": "main4",
    "alignment": "CENTERED",
    "graphic": {
        "value": "img4.png",
        "imageType": "DYNAMIC"
    },
    "softButtons": [{
        "type": "BOTH",
        "softButtonID": 1,
        "text": "ONE",
        "image": {
            "value": "0xD7",
            "imageType": "STATIC"
        }
    }, {
        "type": "BOTH",
        "softButtonID": 2,
        "text": "TWO",
        "image": {
            "value": "0xD8",
            "imageType": "STATIC"
        }
    }],
    "templateTitle": "DOUBLE_GRAPHIC_WITH_SOFTBUTTONS",
    "templateConfiguration": {
        "template": "DOUBLE_GRAPHIC_WITH_SOFTBUTTONS"
    }
}
``
ShobhitAd commented 2 years ago

Seeing an issue with square images in the MEDIA template. There's a size difference between the normal and templated image

Screenshot from 2022-04-01 13-51-27 Screenshot from 2022-04-01 13-51-58