search

smartdevicelink / generic_hmi

A sample HMI to use with sdl_core
BSD 3-Clause "New" or "Revised" License
8 stars 27 forks source link

App Services Modal UI Issues #519

Closed ShobhitAd closed 2 years ago

ShobhitAd commented 2 years ago

Bug Report

Found some UI issues while testing App Services with the Generic HMI:

  1. Service icon not centered in the expanded view

  2. albumLine in app-service-media-card uses the same value as titleLine Screen Shot 2022-04-29 at 1 58 20 PM

  3. Limit the number of digits in the temperature value for WEATHER services

  4. Missing .nav-color in app-services-nav.scss Screen Shot 2022-04-29 at 4 24 28 PM

Testing steps

  1. Add provider app entry in the preloaded policy table
"provider1234": {
                "keep_context": false,
                "steal_focus": false,
                "priority": "NONE",
                "default_hmi": "NONE",
                "groups": ["Base-4","AppServiceProvider"],
                "RequestType": [],
                "RequestSubType": [],
                "app_services": {
                    "MEDIA": {
                        "service_names": ["SDL Music"],
                        "handled_rpcs": [{"function_id": 41}]
                    },
                    "WEATHER": {
                        "service_names": ["SDL Weather"],
                        "handled_rpcs": []
                    },
                    "NAVIGATION": {
                        "service_names": ["SDL Navigation"],
                        "handled_rpcs": [{"function_id": 39},{"function_id": 45},{"function_id": 46},{"function_id": 47},{"function_id": 41}]
                    }
                }
            },
  1. Start core and HMI
  2. Register provider app
  3. For each service type (MEDIA, NAVIGATION, WEATHER) a) Publish service with correct service name. Note the serviceID in the reponse. This should show the app services toolbar and add a service icon. b) Send OnAppServiceData with all fields and the correct serviceID
Browser & Version Information
ShobhitAd commented 2 years ago

Closed via https://github.com/smartdevicelink/generic_hmi/pull/518