Alert image verification ignores original result code - Githubissues

smartdevicelink / generic_hmi

A sample HMI to use with sdl_core

BSD 3-Clause "New" or "Revised" License

8 stars 27 forks source link

Alert image verification ignores original result code #523

Closed jacobkeeler closed 1 year ago

jacobkeeler commented 1 year ago

Bug Report

Alert sends WARNINGS response if images are missing, even when the original result was not SUCCESS

Reproduction Steps

Send alert with missing image name and softbuttons
Wait 10 seconds

Expected Behavior

Alert is dismissed and gets ABORTED response

Observed Behavior

Alert is dismissed and gets WARNINGS response

Browser & Version Information

Browser and Version: Chrome
RPC Sent: {"alertText1":"text","softButtons":[{"type":"BOTH","softButtonID":1,"text":"test","image":{"value":"graphic","imageType":"DYNAMIC"}}]}
Output Received: {success: true, result: "WARNINGS", info: "..."}
Generic HMI Version: master
Testing Against: RPC Builder JS

ShobhitAd commented 1 year ago

Closed via https://github.com/smartdevicelink/generic_hmi/pull/524