search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Mismatch for mandatory parameter between MOBILE_API and HMI_API #1846

Open drauhut1 opened 6 years ago

drauhut1 commented 6 years ago

There is a mismatch for the mandatory parameter between the MOBILE_API and the HMI_API for the following parameters:

The MOBILE_API is reflecting that these parameters are not mandatory, whereas the HMI_API reflects that they are mandatory.

aderiabin commented 6 years ago

Contributor priority is set Medium with reason: The issue is related to API.

robinmk commented 6 years ago

@jacobkeeler , would this be considered as a breaking change and would it be okay to fix this as bug?

HSavynetska commented 4 years ago

The issue is relevant on the current develop branch

Environment: Test script: https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2120 SDL build: https://github.com/smartdevicelink/sdl_core/tree/develop ( 891497b ) ATF: develop branch

jacobkeeler commented 4 years ago

Closing since proposal was accepted and separate issue was submitted: https://github.com/smartdevicelink/rpc_spec/issues/227

GetmanetsIrina commented 3 years ago

@jordynmackool, The issue has been reopened because it was not fixed within smartdevicelink/rpc_spec#227 proposal.

distanceToManeuver and distanceToManeuverScale parameters are still not mandatory in the Mobile API and mandatory in HMI API

Also please notice that the script for this issue is ready for Livio review.

Jack-Byrne commented 3 years ago

FYI this is still a breaking change if we want to change the mandatory values in the mobile api / RPC spec. The proposal does not mention changing those values either. The proposal only mentions a description update.

I believe the proposal requires a revision stating this will be a breaking change to the RPC Spec, and wont be able to complete its implementation until a major version change (Core 8.0).