smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

SDL sometimes sends 2 requests to HMI with the same id #3564

Closed dboltovskyi closed 3 years ago

dboltovskyi commented 4 years ago

Bug Report

SDL sometimes sends 2 requests to HMI with the same id. There is a requirement for SDL that each request should have unique Id.

Occurrences

~0.1% (very rare)

Reproduction Steps
  1. Start SDL
  2. Start HMI
  3. Check Ids of requests from SDL to HMI
Expected Behavior

Ids are unique

Observed Behavior

Sometimes Ids may be the same for 2 different requests:

SDL->HMI [13-10-2020 17:04:39,433] {"id":1,"jsonrpc":"2.0","method":"BasicCommunication.UpdateDeviceList"}
SDL->HMI [13-10-2020 17:04:39,438] {"id":1,"jsonrpc":"2.0","method":"BasicCommunication.GetSystemInfo"}
OS & Version Information
Test Case, Sample Code, and / or Example App
AKalinich-Luxoft commented 3 years ago

@JackLivio @theresalech please notice this PR is ready for Livio review

theresalech commented 3 years ago

@AKalinich-Luxoft thank you for letting us know! This issue was not requested as priority for the next Core release, but we will try to review as time allows. If it's imperative this be included in the next release, please raise as priority to the SDLC Steering Committee. Thanks!

jacobkeeler commented 3 years ago

closing with the merge of #3567