search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Boost Logger Implementation #3571

Closed ShobhitAd closed 3 years ago

ShobhitAd commented 3 years ago

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

Implements a third party logger for sdl core

CLA

ShobhitAd commented 3 years ago

Is sudo necessary for the boost install?

I don't think sudo is necessary to compile and install the boost components. However, since the 3RD_PARTY_INSTALL_PREFIX is set to /usr/local(https://github.com/smartdevicelink/sdl_core/blob/master/src/3rd_party/set_3rd_party_paths.cmake#L50) we do require special permissions to write to that directory.

The install target could be changed but it would end up affecting more than just the boost libraries(libbson and log4cxx). That said, it looks like sudo is only required for the first time setup(when the library is not found). All subsequent builds will not require sudo.