smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Add OnWayPointChange handling for NAVIGATION app services #3573

Closed jacobkeeler closed 3 years ago

jacobkeeler commented 3 years ago

Fixes #3569

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2486

Summary

Add handling for OnWayPointChange notification from NAVIGATION app service. NAVIGATION app service will take over waypoints processing when active if it specifies that it can handle these messages. This allows waypoints to be used even when a system doesn't support this feature directly.

Changelog

Bug Fixes

CLA

dboltovskyi commented 3 years ago

@jacobkeeler Please notice one UT starts failing within the fix:

16:47:21 [==========] 1212 tests from 578 test cases ran. (4358 ms total)
16:47:21 [  PASSED  ] 1211 tests.
16:47:21 [  FAILED  ] 1 test, listed below:
16:47:21 [  FAILED  ] HMICommandsNotificationsTest.OnNaviWayPointChangeSendNotificationToMobile
16:47:21 
16:47:21  1 FAILED TEST

Build Log: SDL_build.log.tar.gz