search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

SDL allows starting Video service for 2nd version of SDL protocol #3576

Closed dboltovskyi closed 3 years ago

dboltovskyi commented 3 years ago

Bug Report

SDL allows starting Auido/Video service for 2nd version of SDL protocol

Reproduction Steps
  1. Register Navi app with 2nd version of SDL protocol
  2. Start Video service
Expected Behavior

SDL responds with StartServiceNACK

Observed Behavior

SDL responds with StartServiceACK

OS & Version Information
Test Case, Sample Code, and / or Example App
dboltovskyi commented 3 years ago

Issue is not reproduced at 7.0.0 and seems introduced by https://github.com/smartdevicelink/sdl_core/pull/3572

dboltovskyi commented 3 years ago

Scripts affected:

./test_scripts/Defects/4_5/1912_Video_service_start_via_2_protocol.lua
./test_scripts/MobileProjection/Phase1/009_Rejecting_audio_video_service_in_FULL_2_protocol.lua
./test_scripts/MobileProjection/Phase1/010_Rejecting_audio_video_service_in_LIMITED_2_protocol.lua
./test_scripts/TheSameApp/Protocol/005_Protocol_StartService_from_2_apps_with_same_appName_diff_appID_DIFF_devices.lua
./test_scripts/TheSameApp/Protocol/006_Protocol_StartService_from_2_apps_with_same_appName_same_appID_DIFF_devices.lua
jacobkeeler commented 3 years ago

Closing with the merge of #3600