smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Fix build failure with ENABLE_LOG=OFF #3604

Closed jacobkeeler closed 3 years ago

jacobkeeler commented 3 years ago

Fixes #3588

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Build with ENABLE_LOG=OFF

Summary

Fix build failure and unused variable warning with ENABLE_LOG=OFF

Changelog

Bug Fixes

CLA

ShobhitAd commented 3 years ago

I am seeing two other unused variable warnings when building with ENABLE_LOG=OFF.

1)

../sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/waypoints_pending_resumption_handler.cc: In member function ‘virtual void sdl_rpc_plugin::WayPointsPendingResumptionHandler::on_event(const application_manager::event_engine::Event&)’:
../sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/waypoints_pending_resumption_handler.cc:157:18: warning: unused variable ‘corr_id’ [-Wunused-variable]
   const uint32_t corr_id = event.smart_object_correlation_id();

2)

../sdl_core/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_app_extension.cc: In member function ‘virtual void rc_rpc_plugin::RCAppExtension::RevertResumption(const ns_smart_device_link::ns_smart_objects::SmartObject&)’:
../sdl_core/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_app_extension.cc:201:14: warning: unused variable ‘module’ [-Wunused-variable]
   for (auto& module : module_subscriptions) {