Feature/sdl 0293 enable oem exclusive apps support

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

241 stars 244 forks source link

Feature/sdl 0293 enable oem exclusive apps support #3616

Closed LitvinenkoIra closed 3 years ago

LitvinenkoIra commented 3 years ago

Implements https://github.com/smartdevicelink/sdl_core/issues/3599

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

ATF test script from https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2517

Summary

Add vehicle data params to StartSessionAck
Postpone StartSessionAck until vehicle data is available

rpc_spec from https://github.com/smartdevicelink/rpc_spec/pull/314

CLA

[x] I have signed the CLA

ashwink11 commented 3 years ago

@jordynmackool this PR is ready for review and is approved by Ford.

iCollin commented 3 years ago

Would you please create the corresponding protocol_spec PR as well?

Version Bump (5.4.0)
StartServiceACK new response parameters
Add message_type 3 to binary headers section

AKalinich-Luxoft commented 3 years ago

Would you please create the corresponding protocol_spec PR as well?

Version Bump (5.4.0)

StartServiceACK new response parameters

Add message_type 3 to binary headers section

@iCollin could you please clarify what doe it mean message_type 3? Is this something related to the feature?

UPD. PR with all feature related changes has been created - https://github.com/smartdevicelink/protocol_spec/pull/36

iCollin commented 3 years ago

could you please clarify what doe it mean message_type 3? Is this something related to the feature?

Thank you for creating that PR.

Message Type 3 is an optional addition as it is not directly related to this feature. I can add the documentation for it.

I requested because I did not know there was a message_type 3 until I reviewed this PR and saw it used here, it is not documented in the protocol spec (which says 0x3-0xF reserved).

AKalinich-Luxoft commented 3 years ago

could you please clarify what doe it mean message_type 3? Is this something related to the feature?

Thank you for creating that PR.

Message Type 3 is an optional addition as it is not directly related to this feature. I can add the documentation for it.

I requested because I did not know there was a message_type 3 until I reviewed this PR and saw it used here, it is not documented in the protocol spec (which says 0x3-0xF reserved).

@iCollin thanks for explanation. I pushed one more commit into the protocol_spec PR with the required changes

jordynmackool commented 3 years ago

@AKalinich-Luxoft the proposal markdown file has been updated per the revisions included in the accepted with revisions review issue: SDL 0293 Revisions - Enable OEM exclusive apps support.

Please make the needed updates to this PR and then tag @iCollin to review when ready. Thanks!

AKalinich-Luxoft commented 3 years ago

@iCollin this PR is ready for Livio review