SDL does not respond with NACK to start RPC service request with invalid data - Githubissues

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

241 stars 244 forks source link

SDL does not respond with NACK to start RPC service request with invalid data #3620

Closed dboltovskyi closed 3 years ago

dboltovskyi commented 3 years ago

Bug Report

SDL does not respond with NACK to start RPC service request with invalid data

Reproduction Steps

Start SDL, HMI, connect mobile device
App tries to start RPC service over 5th SDL protocol with invalid data in bson payload

Expected Behavior

SDL does:

send 'OnServiceUpdate' notification to HMI with 'REQUEST_REJECTED'
respond with NACK to start service request with appropriate reason

Observed Behavior

SDL does:

send 'OnServiceUpdate' notification to HMI with 'REQUEST_REJECTED'
not send StartServiceNack to mobile app

OS & Version Information

OS/Version: Ubuntu 18.04
SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/develop (61ea4ef)
Testing Against: ATF

Test Case, Sample Code, and / or Example App

ATF Script: 3620.lua.tar.gz
Report and Logs: 2021-01-25_21-30-42.461_3620.tar.gz

LitvinenkoIra commented 3 years ago

@VladSemenyuk is working on it

iCollin commented 3 years ago

Closed via https://github.com/smartdevicelink/sdl_core/pull/3647