SDL response with "GENERIC_ERROR" in case request ResetGlobalProperties ("USER_LOCATION")

VjKlepikov commented 3 years ago

Bug Report

Precondition:

1. Start SDL and HMI.
2. Connect mobile device via any transport.
3. Mobile application is registered and activated.
4. Mobile application successfully sends SetGlobalProperties with userLocation parameter
 SetGlobalProperties { "userLocation":{"grid": {"col":2, "level":2,"row":2, "colspan":1,"levelspan":1, "rowspan":1 }

Reproduction Steps

Send ResetGlobalProperties with "USER_LOCATION" App→SDL: ResetGlobalProperties (USER_LOCATION)

Expected Behavior

SDL sends RC.SetGlobalProperties request with default driver seat location properties to HMI SDL→HMI: RC.SetGlobalProperties ( { "userLocation":{"grid":{"col":0, "level":0,"row":0, "colspan":1,"levelspan":1, "rowspan":1 }}} HMI→SDL: RC.SetGlobalProperties ( SUCCESS ) SDL→App: ResetGlobalProperties( "success":true, resultCode":"SUCCESS" )

Observed Behavior

SDL→App: ResetGlobalProperties( "success":false , "resultCode":"GENERIC_ERROR")

SDL_logs:

SDL_Log.zip

OS & Version Information

OS/Version: Ubuntu 18.04
SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/develop (c9fc559)
Testing Against: HMI: https://github.com/smartdevicelink/sdl_hmi/tree/develop (41c804d), SPT: SPT: 20210305-Android (1076)

VjKlepikov commented 3 years ago

@yang1070 Could you please confirm the expected result: SDL sends RC.SetGlobalProperties request with default driver seat location properties to HMI RC.SetGlobalProperties ( { "userLocation":{"grid":{"col":0, "level":0,"row":0, "colspan":1,"levelspan":1, "rowspan":1 }}}

yang1070 commented 3 years ago

@VjKlepikov According to the proposal https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0221-multiple-modules.md The default userLocation should be DRIVER's seat to ensure backwards compatibility. Therefore, grid":{"col":0, "level":0,"row":0, "colspan":1,"levelspan":1, "rowspan":1 }} is correct

ShobhitAd commented 3 years ago

Closed via https://github.com/smartdevicelink/sdl_core/pull/3741

smartdevicelink / sdl_core