search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Store resumption data in storage folder #3686

Closed jacobkeeler closed 3 years ago

jacobkeeler commented 3 years ago

Copy of https://github.com/smartdevicelink/sdl_core/pull/2195

Fixes https://github.com/smartdevicelink/sdl_core/issues/2194

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Repeat the steps mentioned in https://github.com/smartdevicelink/sdl_core/issues/2194 and make sure that app_info.dat file is stored in "storage" folder.

Summary

This PR changes the location of Application info file (app_info.dat) to the directory specified by AppStorageFolder in the ini file.

Changelog

Breaking Changes
Enhancements
Bug Fixes

Tasks Remaining:

CLA

iCollin commented 3 years ago

Something in these changes seems to be causing a few ATF failures where the tests are expecting a different device ID:

test_scripts/Defects/5_0/2457_Needed_fixes_sending_of_UpdateDeviceList_notification_on_device_connect.lua
test_scripts/WebEngine/WebEngineProjection/017_Show_RPC_to_Main_Window_widget_without_DuplicateID.lua
test_scripts/WebEngine/WebEngineProjection/018_Show_RPC_to_Main_Window_widget_with_DuplicateID.lua
test_scripts/WebEngine/WebEngineProjection/019_Processing_show_rpc.lua
jacobkeeler commented 3 years ago

@iCollin These tests pass on my end, are you using both https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2542 and https://github.com/smartdevicelink/sdl_atf/pull/226?