Open INI file less - Githubissues

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

241 stars 244 forks source link

Open INI file less #3688

Closed iCollin closed 3 years ago

iCollin commented 3 years ago

Fixes https://github.com/smartdevicelink/sdl_core/issues/2850

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Change INI value, run SDL core, ensure Core read new INI value Unit Tests and ATF tests

Summary

Refactor INI parsing to reduce the number of times the ini file is opened. This goal is achieved through an update to Profile::UpdateValues:

INI file is opened
all values from the file are read into a smart_object
INI files is closed
Member variables are assigned from values in smart_object

Changelog

Enhancements

SDL Core should open the ini file many times less

CMake

transport_manager now requires smart_object include
config_profile now depends on smart_object
config_profile_test now depends on smart_object

Tasks Remaining:

[x] Fix unit tests
[x] Remove ini_file changes
[x] Deprecate ini_file?

CLA

[x] I have signed the CLA

iCollin commented 3 years ago

PR description is updated for the new approach