search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Remove logic sending invalid slider position #3697

Closed jacobkeeler closed 3 years ago

jacobkeeler commented 3 years ago

Fixes #3676

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Manual testing against SDL HMI PR (https://github.com/smartdevicelink/sdl_hmi/pull/564), app should receive sliderPosition in ABORTED or TIMED_OUT response for Slider if provided by the HMI.

Summary

sliderPosition was being set to 0 (an invalid value) in the mobile response for Slider if an ABORTED or TIMED_OUT result was received from the HMI without this parameter. This PR removes that logic.

Changelog

Bug Fixes

CLA

Jack-Byrne commented 3 years ago

@jacobkeeler Do you think we might need to add documentation to the integration guidelines or update the HMI API description to note that TIMEOUT and ABORTED result codes that include the slider position must be sent in a success response format?