Core Crash noticed with Invalid PTU - Githubissues

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

241 stars 244 forks source link

Core Crash noticed with Invalid PTU #3698

Closed iCollin closed 3 years ago

iCollin commented 3 years ago

Bug Report

Core can be crashed with PTU binary data

Reproduction Steps

build with USE_HMI_PTU_DECRYPTION OFF and PROPRIETARY_MODE ON
Start Core & HMI, connect app, trigger PTU
send SystemRequest response with bulkData that is not an object (ex. string "crash")

Expected Behavior

Core does not crash

Observed Behavior

Core crashes

OS & Version Information

SDL Core Version: develop

Test Case, Sample Code, and / or Example App

https://github.com/SmartDeviceLink-Examples/rpc_builder_app_js/blob/react/feature/react/src/components/menu/AppConfig.jsx#L187

change to uint8encoder.encode('"crash"')

iCollin commented 3 years ago

Closed via https://github.com/smartdevicelink/sdl_core/pull/3699