search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

[SDL 0338] Remove Unused Files From SDL Core #3722

Closed theresalech closed 3 years ago

theresalech commented 3 years ago

Proposal: Remove Unused Files From SDL Core

This proposal is to remove some unused utility and RPC files in SDL Core.

Review: https://github.com/smartdevicelink/sdl_evolution/issues/1152

ychernysheva commented 3 years ago

Hi @JackLivio We have noticed that there are another unused notifications in SDLRPCPlugin code base, besides of OnVIBeltStatusNotification and OnVIAccPedalPositionNotification. It seems that OnVIBodyInformationNotification, OnVIDeviceStatusNotification, OnVIDriverBrakingNotification, OnVIEngineTorqueNotification, OnVIExternalTemperatureNotification, OnVIFuelLevelNotification, OnVIFuelLevelStateNotification, OnVIGpsDataNotification, OnVIHeadLampStatusNotification, OnVIInstantFuelConsumptionNotification, OnVIMyKeyNotification, OnVIOdometerNotification, OnVIPrndlNotification, OnVIRpmNotification, OnVISpeedNotification, OnVISteeringWheelAngleNotification, OnVITirePressureNotification, OnVIVinNotification, OnVIWiperStatusNotification are also unused and probably should to be removed. May I kindly suggest to include them in the scope of this proposal, or my team may create separate issue for this task?

Jack-Byrne commented 3 years ago

Thank you for the note, I will look at revising the accepted proposal.

theresalech commented 3 years ago

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0338 Revisions - Remove Unused Files From SDL Core. Revisions include additional unused files to be removed. Please reference this pull request for details.

theresalech commented 3 years ago

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0338 Revisions - Remove Unused Files From SDL Core. Revisions include keeping two files that were found to be used in the project. Please reference this pull request for details.

Jack-Byrne commented 3 years ago

PR merged