search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 244 forks source link

Fix handling of RC.SetGlobalProperties response #3741

Closed AKalinich-Luxoft closed 3 years ago

AKalinich-Luxoft commented 3 years ago

Fixes #3668

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Can be reproduced manually:

Expected Behavior SDL sends RC.SetGlobalProperties request with default driver seat location properties to HMI SDL→HMI: RC.SetGlobalProperties ( { "userLocation":{"grid":{"col":0, "level":0,"row":0, "colspan":1,"levelspan":1, "rowspan":1 }}} HMI→SDL: RC.SetGlobalProperties ( SUCCESS ) SDL→App: ResetGlobalProperties( "success":true, resultCode":"SUCCESS" )

Observed Behavior SDL→App: ResetGlobalProperties( "success":false , "resultCode":"GENERIC_ERROR")

Summary

SDL sends RC.SetGlobalProperties request to HMI, however does not process a response from HMI. There was added processing of RC part of the request and covered by new unit test to fix that.

CLA

AKalinich-Luxoft commented 3 years ago

@theresalech this PR is ready for Livio review

jordynmackool commented 3 years ago

@AKalinich-Luxoft please see review feedback from Shobhit above. Thanks!