smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Remove unnecessary default_timeout_ adjustments after 0189 #3759

Closed iCollin closed 3 years ago

iCollin commented 3 years ago

Many of the interaction RPCs currently have their HMI timeout adjusted by Core; that ​is no longer necessary after the implementation of 0189. This affects Alert, SubtleAlert, Slider, and ScrollableMessage.

Lines such as the following are no longer necessary:

https://github.com/smartdevicelink/sdl_core/blob/042872f24b2cf7d9c1b18cab81d502071de4b5a7/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/ui_alert_request.cc#L55

jacobkeeler commented 3 years ago

Closing, see https://github.com/smartdevicelink/sdl_core/pull/3760#issuecomment-902868563