search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Add missing internal error codes to security manager #3773

Closed jacobkeeler closed 3 years ago

jacobkeeler commented 3 years ago

Adds missing security query specification details from https://github.com/smartdevicelink/protocol_spec/issues/40

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

HANDSHAKE_FAILED - can be triggered by setting VerifyPeer=true using the Java Security Lib Example Certificates INVALID_CERT - can be triggered by sending an app certificate with an app ID which is different from the one that the app registered with EXPIRED_CERT - can be triggered by sending an expired app certificate (or by modifying the GetSystemTime response from the HMI)

Summary

Adds logic for missing error codes in SendInternalError query (HANDSHAKE_FAILED, ERROR_INVALID_CERT, and ERROR_EXPIRED_CERT)

Changelog

Bug Fixes

CLA