search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Invalid data in BC.UpdateAppList for WebEngine app #3797

Closed GetmanetsIrina closed 2 years ago

GetmanetsIrina commented 2 years ago

Bug Report

Invalid data in BC.UpdateAppList for WebEngine app

Reproduction Steps
  1. Core is built with DWEBSOCKET_SERVER_TRANSPORT_SUPPORT set to true
  2. In sdl_preloaded_pt.json default app_policies groups: ["Base-4" ]
  3. SDL and HMI are started
  4. Run deploy_server.sh file in HMI directory
  5. On HMI → Apps →Apps Store → Set Apps Properties → Set
Expected Behavior
HMI → SDL: SetAppProperties ( properties:
{nicknames:{ "Hello JS" } ,
policyAppID:"hello-js",
enabled: true,
transportType:"ws",
hybridAppPreference: "BOTH"})
SDL → HMI: SetAppProperties ( { success:true, resultCode: "SUCCESS" } )
SDL → HMI: UpdateAppList request {"applications":[{"appID":1251837608,"appName":"Hello JS","deviceInfo":"id":"558302f84258903819b64191998d9c8b8ce613e5b4d0153ca93343c09553792e","isSDLAllowed":true,"name":"Web Engine","transportType":"WEBENGINE_WEBSOCKET"},"greyOut":false,"isCloudApplication":false,"policyAppID":"hello-js","requestSubType":[],"requestType":[]}]}}
HMI → SDL: UpdateAppList response{SUCCESS}
Observed Behavior
SDL -> HMI [17:53:37:477]: {"id":2,"jsonrpc":"2.0","method":"BasicCommunication.UpdateAppList","params":{"applications":[{"appID":38803992,"appName":"Hello JS","deviceInfo":{"id":"558302f84258903819b64191998d9c8b8ce613e5b4d0153ca93343c09553792e","isSDLAllowed":true,"name":"Web Engine","transportType":"WEBENGINE_WEBSOCKET"},"hmiDisplayLanguageDesired":-1,"isCloudApplication":false,"isMediaApplication":false,"policyAppID":"hello-js","requestSubType":[],"requestType":[]}]}}

SDL sends invalid value for hmiDisplayLanguageDesired, redundant isMediaApplication and does not send greyOut parameters.

OS & Version Information
dboltovskyi commented 2 years ago

@theresalech Please notice this is a regression issue which is likely introduced by https://github.com/smartdevicelink/sdl_core/pull/3796. Luxoft team is going to prepare a fix.

dboltovskyi commented 2 years ago

@theresalech Please notice following PRs are ready for Livio team review:

iCollin commented 2 years ago

Fixed via https://github.com/smartdevicelink/sdl_core/pull/3799