search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Update minimum value of MaxSupportedProtocolVersion to 2 #3801

Closed jacobkeeler closed 2 years ago

jacobkeeler commented 2 years ago

Fixes https://github.com/smartdevicelink/sdl_core/issues/3818

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Set MaxSupportedProtocolVersion to 1, verify that app registers with protocol version 2 instead

Summary

If MaxSupportedProtocolVersion is set to 1, no apps can register because SDL Core responds with UNSUPPORTED_VERSION to protocol V1 messages (besides the initial StartService). This PR updates the minimum value of MaxSupportedProtocolVersion to 2.

Changelog

Bug Fixes

CLA