search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Core assumes application will remain valid thru registration process #3813

Closed iCollin closed 2 years ago

iCollin commented 2 years ago

Bug Report

It was noticed that Core assumes applications_ entry will be valid throughout the registration process, when the applications_ entry may be removed.

Reproduction Steps
  1. Register some apps
  2. Change language quickly
Expected Behavior

Registration process completes successfully

Observed Behavior

application == nullptr in either of the following methods: (depending on timing)

commands::RegisterAppInterfaceRequest::CheckLanguage()
sdl_rpc_plugin::commands::FinishSendingResponseToMobile(...)
OS & Version Information
iCollin commented 2 years ago

Closed via https://github.com/smartdevicelink/sdl_core/pull/3815