search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Avoid processing streaming data packets after streaming stopping #3816

Closed ychernysheva closed 2 years ago

ychernysheva commented 2 years ago

Fixes #3811

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Covered by ATF test scripts

Summary

In some situations streaming data packets may be received during streaming stopping. In this case processing of such packet will be performed right after completion of streaming stopping process due to streaming_stop_lock_. So in this case we need to skip processing of such packet, that's why new flags video_streaming_stopped_ and audio_streaming_stopped_ are added for both services. Also outdated comments are removed with locks, which now are redundant due to presence of streaming_stop_lock_.

CLA

ychernysheva commented 2 years ago

@theresalech this PR is ready for Livio review

LitvinenkoIra commented 2 years ago

@iCollin We are doing regression testing right now, I’ll let you know when this PR is ready for re-review

GetmanetsIrina commented 2 years ago

@iCollin Looks like scripts have been failed because of not corresponding script version. I had the same issue, but with the latest version of scripts (167bdd1) I have PASS status.

PR is ready for review.

iCollin commented 2 years ago

Thank you, yes I see all test passing now. This comment is still applicable, and after that this should be good to merge.