smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

SDL does not resend OnButton notifications for custom buttons that were added within ShowConstantTBT, UpdateTurnList RPCs #3829

Closed VjKlepikov closed 2 years ago

VjKlepikov commented 2 years ago

Bug Report

SDL does not resend OnButton notifications for custom buttons that were added within ShowConstantTBT, UpdateTurnList RPCs Please notice this is a issue which was introduced by fix https://github.com/smartdevicelink/sdl_core/pull/2629

Reproduction Steps
  1. SDL and HMI are started
  2. Mobile app has assigned "Navigation-1" policy group
  3. Mobile app is registered and activated (SDL automatically adds subscription for the CUSTOM_BUTTONS during registration)
  4. Mobile app requests ShowConstantTBT and UpdateTurnList RPCs with softButtons(DEFAULT_ACTION)
  5. Press added soft buttons HMI sends OnButtonPress and OnButtonEvent notifications to SDL
Expected Behavior

SDL resends OnButtonPress and OnButtonEvent notifications to the mobile app

Observed Behavior

SDL does not resend OnButtonPress and OnButtonEvent notifications to the mobile app

Note: SDL immediately unsubscribes from softButtons after ShowConstantTBT and UpdateTurnList responses from HMI

OS & Version Information
VjKlepikov commented 2 years ago

@theresalech Please notice Luxoft team is planning to provide a fix and test scripts

iCollin commented 2 years ago

Closed via https://github.com/smartdevicelink/sdl_core/pull/3839