search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Cyclic UpdateDeviceList and UpdateAppList in case device is connected #3835

Closed RomanReznichenkoLuxoft closed 2 years ago

RomanReznichenkoLuxoft commented 2 years ago

Fixes #3346

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

Core runs scripts for thread delegates at intervals. Bluetooth is constantly running an event of type ON_DEVICE_LIST_UPDATED, but we do not receive new devices to connect. So I added a check to abort the script with an empty device list. When we connect the device, it acquires the status of connected, but we only checked the response of the ConnectDevice function. Because of this, after connecting the device, we constantly run an event of type ON_CONNECTION_STATUS_UPDATED. UpdateAppList is called when processing this event.

CLA

RomanReznichenkoLuxoft commented 2 years ago

@jordynmackool This PR is ready for Livio review

LitvinenkoIra commented 2 years ago

@jacobkeeler We are doing regression testing right now, I’ll let you know when this PR is ready for re-review

LitvinenkoIra commented 2 years ago

@jacobkeeler This PR is ready for review.