smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
241 stars 245 forks source link

Driver Distraction Notification does not include Lock Screen Dismissal information when state=DD_OFF #3841

Closed joeljfischer closed 2 years ago

joeljfischer commented 2 years ago

Bug Report

When connecting to the Generic_HMI, an initial driver distraction notification is sent, but that DD notification doesn't include the lock screen dismissal enabled parameter, nor lock screen text. This information should be included so that lock screen dismissal is enabled before a second DD notification is received.

Reproduction Steps
  1. Watch for the first DD notification
  2. Connect to Core + generic_hmi
  3. View the DD notification
  4. Toggle DD
  5. View the second DD notification
Expected Behavior

The initial DD notification should include lock screen dismissal information

Observed Behavior

The initial DD notification does not include lock screen dismissal information, but the second DD notification does

Browser & Version Information
Test Case, Sample Code, and / or Example App

n/a

jacobkeeler commented 2 years ago

The Generic HMI doesn't provide these values. They are provided by Core using the policy table, and these values are only sent in the DD_ON case, per Core's logic. Are you setting DD_ON before connecting the app?

joeljfischer commented 2 years ago

@jacobkeeler Sorry, this should have included more information and is on the wrong repository. Even when Driver Distraction is off, the lock screen dismissibility information should be included because an app can present the lock screen even when driver distraction is OFF but may want to be dismissible if the head unit allows it. This is a fringe case, but it is one in our smoke test sheet.

jacobkeeler commented 2 years ago

Closed via #3842