Fix invalid iterator usage in clusterModes check

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

241 stars 245 forks source link

Fix invalid iterator usage in clusterModes check #3843

Closed jacobkeeler closed 2 years ago

jacobkeeler commented 2 years ago

Fixes Coverity CID 243800 (introduced in #3830)

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Run vehicle data ATF tests

Summary

Fixes invalid iterator usage in vehicle_info_pending_resumption_handler.cc introduced in #3830

Changelog

Bug Fixes

Fixes invalid iterator usage in vehicle_info_pending_resumption_handler.cc

CLA

[x] I have signed the CLA

jacobkeeler commented 2 years ago

After further investigation, this PR does not fix #3460, just the cited Coverity issue. The following tests still fail with this PR:

./test_scripts/API/VehicleData/SubscribeVehicleData/015_SubscribeVD_allowed_and_disallowed_after_PTU.lua
./test_scripts/API/VehicleData/UnsubscribeVehicleData/012_UnsubscribeVD_allowed_and_disallowed_after_PTU.lua