SDL removes the current "consumer_friendly_messages" section in Local PT in case the Updated PT omits "consumer_friendly_messages" section

VjKlepikov commented 2 years ago

Bug Report

Reproduction Steps

Make sure SDL is built with HTTP flow
Register new application => PTU is triggered
PTU omits "consumer_friendly_messages" section

Expected Behavior

SDL maintains the current "consumer_friendly_messages" section in Local PT

Observed Behavior

SDL removes the current "consumer_friendly_messages" section in Local PT in case the Updated PT omits "consumer_friendly_messages" section

OS & Version Information

OS/Version: Ubuntu 18
SDL Core Version: https://github.com/smartdevicelink/sdl_core/tree/develop (6ca6961)

Test Case, Sample Code, and / or Example App

Tests scripts: *./test_scripts/Policies/build_options/070_ATF_PTU_Merge_Into_Local_PT_ConsumerFriendlyMessages_Omitted_HTTP.lua

Logs: Logs.zip

VjKlepikov commented 2 years ago

Please notice this is a regression issue that became reproducible after merge of #3842 @theresalech Can you please advise if the Livio team is planning on submitting a PR to fix?

theresalech commented 2 years ago

@VjKlepikov our team will review the issue and advise.

jacobkeeler commented 2 years ago

@VjKlepikov can you confirm if this issue only occurs in HTTP mode?

jacobkeeler commented 2 years ago

After testing, it appears that this issue is reproducible in master if OnDriverDistraction(DD_ON) is sent prior to registering the app. It seems likely that the issue lies in this section of code

jacobkeeler commented 2 years ago

closed via #3852

smartdevicelink / sdl_core