smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
240 stars 245 forks source link

Fix crash on shutdown during streaming #3876

Closed Jack-Byrne closed 2 years ago

Jack-Byrne commented 2 years ago

Fixes https://github.com/smartdevicelink/sdl_core/issues/3878

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Summary

A request pointer was being added to the notification struct, but the init or check permissions call were failing so the notification never even ran or had the chance to be removed from the notification list.

Updated the logic to only add the notification to the notificationlist if it is properly init.

CLA