search

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
240 stars 245 forks source link

SDL rejects SystemRequest from mobile App during PTU in case HMI sends BC.OnSystemRequest with 'url' parameter #3881

Closed VjKlepikov closed 2 years ago

VjKlepikov commented 2 years ago

Bug Report

SDL rejects SystemRequest from mobile App during PTU in case HMI sends BC.OnSystemRequest with url parameter

Reproduction Steps

SDL is built in PROPRIETARY policy mode Core and HMI are started App is registered SDL sends OnStatusUpdate(UPDATING) HMI sends OnSystemRequest with 'url' parameter SDL send OnSystemRequest to App App sends SystemRequest(PROPRIETARY) to SDL

Expected Behavior

SDL sends SystemRequest(SUCCESS) response to mobile App

Observed Behavior

SDL rejects SystemRequest from mobile App

OS & Version Information
Logs:

Logs_P.zip

VjKlepikov commented 2 years ago

@theresalech Please notice this is a regression issue that became reproducible after merge of https://github.com/smartdevicelink/sdl_core/pull/3853

Jack-Byrne commented 2 years ago

@VjKlepikov Can you provide the atf test you were using for this issue please?

VjKlepikov commented 2 years ago

@JackLivio Issue has been found during manual testing with enable External Policies option on Web-HMI Also please find draft script to check the issue https://github.com/smartdevicelink/sdl_atf_test_scripts/commit/c87e1a0fa1abadd46573b046d523e572d58923bd

Jack-Byrne commented 2 years ago

@VjKlepikov I confirmed my pr fixes the issue for both external and proprietary policy builds. Could you please open a pr with those atf changes when finalized?

VjKlepikov commented 2 years ago

@JackLivio Yes, Luxoft team is going to prepare ATF script(s) to verify it

VjKlepikov commented 2 years ago

@JackLivio Please find PR with ATF script(s) to check the issue https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2651 Please note SDL rejects SystemRequest from mobile App during PTU for several apps in case HMI sends BC.OnSystemRequest with 'url' parameter Sometimes test script is FAILED https://github.com/LuxoftSDL/sdl_atf_test_scripts/blob/defects/3881/test_scripts/Policies/Policy_Table_Update/177_PTU_is_performed_for_several_Apps_if_HMI_sends_BC_OnSystemRequest_with_url_parameter.lua logs: Logs.zip SDL: fix/issue_3881 (bf9e4e4d)