Add missed locks - Githubissues

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

240 stars 245 forks source link

Add missed locks #3890

Closed RomanReznichenkoLuxoft closed 2 years ago

RomanReznichenkoLuxoft commented 2 years ago

Fixes https://github.com/smartdevicelink/sdl_core/issues/3855

This PR is ready for review.

Risk This PR makes no API changes.

Testing Plan ATF scripts

Summary Added missed locks in cash_manager for proprietary mode Added new mutex for protecting policy table snapshot in policy_manager_impl

CLA

[x] I have signed the CLA

LitvinenkoIra commented 2 years ago

@theresalech This PR is ready for Livio review!

Jack-Byrne commented 2 years ago

Hello @LitvinenkoIra and @RomanReznichenkoLuxoft. The description mentions missed locks for proprietary and external proprietary policy modes but I do not see any changes to the external policy specific files?

Jack-Byrne commented 2 years ago

~~Also this test is still failing that was mentioned in this issue comment: https://github.com/smartdevicelink/sdl_core/issues/3855#issuecomment-1070604530~~

Sorry i think i had a bad environment, everything is passing

RomanReznichenkoLuxoft commented 2 years ago

I edited the description. The same changes are already in the external mode on the developer.