Check iterator before erase in ProcessResponseFromHMI

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

239 stars 245 forks source link

Closed OlhaVorobiova closed 1 year ago

OlhaVorobiova commented 2 years ago

Fixes #3910

This PR is ready for review.

This PR makes no API changes.

In rare case, two threads try to process response from hmi with same correlation id and function id (from HandleOnEvent and HandleOnTimeOut)

Added a checking of iterator before an erasing of request
Changed return value for method void EraseProcessedRequest (...) to bool IsErasedProcessedRequest(...) . It's for checking if this request has already been processed.

OlhaVorobiova commented 2 years ago

@theresalech This PR is ready for Livio review.