SDL requests invalid VR.AddCommand during CreateInteractionChoiceSet resumption without VR part

smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI

BSD 3-Clause "New" or "Revised" License

242 stars 244 forks source link

SDL requests invalid VR.AddCommand during CreateInteractionChoiceSet resumption without VR part #3936

Closed OlhaVorobiova closed 2 years ago

OlhaVorobiova commented 2 years ago

Fixes #3888

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

Modified creation messages for AddCommand DeleteCommand requests Added check of vr part in VRAddCommandRequest Added check of grammar_id in VRDeleteCommandRequest Added unit tests

CLA

[x] I have signed the CLA

OlhaVorobiova commented 2 years ago

@theresalech This PR is ready for Livio review.

ShobhitAd commented 2 years ago

Closed in favor of https://github.com/smartdevicelink/sdl_core/pull/3938