smartdevicelink / sdl_core

SmartDeviceLink In-Vehicle Software and Sample HMI
BSD 3-Clause "New" or "Revised" License
242 stars 244 forks source link

Fix PrepareResultForMobileResponse logic #3943

Closed jacobkeeler closed 2 years ago

jacobkeeler commented 2 years ago

Fixes https://github.com/smartdevicelink/sdl_core/issues/3942

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Run ATF regression, plus manually test using the steps in the linked issue

Summary

Fixes logic of 3-args overload of PrepareResultForMobileResponse, only returning true if at least two of the checks are successful (meaning that one response was successful and the other two were non-error responses)

Changelog

Bug Fixes

CLA