search

smartdevicelink / sdl_evolution

Tracking and proposing changes to SDL's public APIs.
https://smartdevicelink.github.io/sdl_evolution/
BSD 3-Clause "New" or "Revised" License
33 stars 122 forks source link

Revise SDL 0338 - Remove Unused Files From SDL Core #1173

Closed Jack-Byrne closed 2 years ago

Jack-Byrne commented 2 years ago

Introduction

This is a revision to an accepted proposal. The revision is to keep two files that were found to be used in the project.

Motivation

During the implementation of this proposal it was found that system.cc and system.h are still used by SDL Core and should not be removed from the project.

Proposed Solution

Update the proposal to not include system.cc and system.h in the list of files to remove.

Potential Downsides

The author does not see any potential downsides that weren't already addressed in the original proposal.

Impact On Existing Code

system.cc and system.h will be kept in the SDL Core project.

Alternatives Considered

The alternative would be to completely revert the original proposal.

Jack-Byrne commented 2 years ago

@theresalech Ready for review