[Accepted with Revisions] SDL 0216 - Widget support

[jordynmackool]

Hello SDL community,

The review of the revised "SDL 0216 - Widget Support" begins now and runs through May 14, 2019. Previous reviews of this proposal took place March 20 - April 9, 2019 and January 23 - February 26, 2019. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0216-widget-support.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

https://github.com/smartdevicelink/sdl_evolution/issues/664

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

• Is the problem being addressed significant enough to warrant a change to SDL?
• Does this proposal fit well with the feel and direction of SDL?
• If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
• How much effort did you put into your review? A glance, a quick reading, or an in-depth study? Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you, Jordyn Mackool

[Jack-Byrne]

@kshala-ford

16 iii) If the enum is preferred then we could just remove the documentation tag from AppServiceType. Also there are no capabilities for what AppServiceTypes the HMI supports but it could be inferred from the rpc spec version core is using.

[kshala-ford]

Thank you @JackLivio but I believe your original concern is valid, therefore in the RPC spec the parameter type should be changed to String. In the library implementation we can offer the enum though. This would ensure modern apps to allow use new enum values on older vehicles (e.g. VOIP might be added in future and an app uses it but some vehicles won't support VOIP).

[kshala-ford]

Sorry for the spam but I wanted to inform you about the PR #729 which includes revisions as we have found an agreement to all items:

|8 Rename duplicateWindowID to duplicateUpdatesFromWindowID

|16 Add PRIMARY_WIDGET to PredefinedWindows. This predefined widget is used by the HMI whenever a single widget needs to represent the whole app (e.g. recent apps widget).

|16 iii) Change "widgetType" type from AppServiceType to String

|17 No action.

|18 Made windowID to optional for OnAppActivated and OnAppDeactivated

|19 Templates and color schemes are set with a struct (as Joey's suggestion). The struct is called TemplateConfiguration.

|20 no action

|21 textSupported flag is added to SoftButtonCapabilities (thank you Joey for your suggestion)

|22 no action

[theresalech]

The Steering Committee voted to accept this proposal with the agreed upon revisions, described in this comment and included in PR #729.

[theresalech]

Proposal updated to reflect agreed upon revisions, issues entered: Java Suite iOS Core RPC SDL HMI