smartdevicelink / sdl_evolution

Tracking and proposing changes to SDL's public APIs.
https://smartdevicelink.github.io/sdl_evolution/
BSD 3-Clause "New" or "Revised" License
33 stars 122 forks source link

[Accepted with Revisions] SDL 0221 Revisions - Remote Control - Allow Multiple Modules per Module Type #791

Closed theresalech closed 5 years ago

theresalech commented 5 years ago

Hello SDL community,

The review of "Revise SDL-0221 Remote Control - Allow Multiple Modules per Module Type" begins now and runs through July 30, 2019. This will be a review of proposed revisions to a previously accepted but not yet implemented proposal, SDL 0221.

The pull request outlining the revisions under review is available here:

https://github.com/smartdevicelink/sdl_evolution/pull/786

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

https://github.com/smartdevicelink/sdl_evolution/issues/791

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you, Theresa Lech

Program Manager - Livio theresa@livio.io

Jack-Byrne commented 5 years ago
  1. If a mobile app uses the SupportedSeat id and omits moduleId in a RPC request, SDL shall add the moduleId parameter to HMI request according to the following rules:

Eventually "id" will be marked removed from the mobile api in version 7.0. Are these the behaviors for core only when the app registers and negotiates as a <=6.0 rpc spec version? In other words a >= 7.0 rpc app that sends "id" should get an invalid data error returned.

2.

if id = FRONT_PASSENGER then moduleId = moduleId of second published module in seatControlCapabilities

This creates the requirement that order now matters. When you say published module do you mean the results of HMI RPC RC.GetCapabilities?

  1. If a mobile app includes both SupportedSeat id and moduleId in a RPC request, SDL shall forward the request as is to HMI.

This should only apply to apps that negotiate a >= 6.0 and < 7.0 rpc spec version.

LuxoftAKutsan commented 5 years ago
  1. Correct
  2. Yes.
  3. Yes.
theresalech commented 5 years ago

The Steering Committee voted to accept this proposal with revisions. The revisions will include adding clarifying language, specifying behavior for specific versions, as outlined in this comment from the Project Maintainer.

theresalech commented 5 years ago

@LuxoftAKutsan please advise when PR #786 has been updated to reflect these agreed upon revisions. I'll then merge the PR so the proposal file is up to date, and make note of these changes on the respective implementation issues for SDL 0221. Thanks!

theresalech commented 5 years ago

Agreed upon revisions have been added to PR, and PR has been merged, so proposal file is now up to date. Comments have been left on implementation issues to call out these revisions: SDL HMI Java Suite iOS RPC Spec Core