search

smartdevicelink / sdl_evolution

Tracking and proposing changes to SDL's public APIs.
https://smartdevicelink.github.io/sdl_evolution/
BSD 3-Clause "New" or "Revised" License
33 stars 122 forks source link

[Accepted] SDL 0288 - Screen Manager Play Audio #962

Closed theresalech closed 4 years ago

theresalech commented 4 years ago

Hello SDL community,

The review of "SDL 0288 - Screen Manager Play Audio" begins now and runs through March 17, 2020. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0288-screen-manager-play-audio.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

https://github.com/smartdevicelink/sdl_evolution/issues/962

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you, Theresa Lech

Program Manager - Livio theresa@livio.io

Sohei-Suzuki-Nexty commented 4 years ago

In this proposal, only TTS is targeted, how do you handle other audio features such as AudioStreaming? In addition, some other proposals also target ScreenManager features, but how much functions will be targeted to whole ScreenManager?　 I care about how much functions will be targeted.

joeljfischer commented 4 years ago

Hello @Sohei-Suzuki, this proposal is targeted at only one API, the Speak RPC, and making it available to developers through the screen manager API. Audio streaming and other features are outside of the scope of this proposal, and have already been proposed and implemented elsewhere.

I'm not sure what you're saying here:

In addition, some other proposals also target ScreenManager features, but how much functions will be targeted to whole ScreenManager?　 I care about how much functions will be targeted.

Could you please clarify?

Shohei-Kawano commented 4 years ago

Hi @joeljfischer -san

Thank you for replying to my team member. He is already out of office today. So I will reply to you.

and have already been proposed and implemented elsewhere.

Could you tell us which Proposal?

Could you please clarify?

We feel that ScreenManager is a very useful module. And I feel that ScreenManager supports many features. However, since Proposal is divided, the whole picture of the function that ScreenManager supports is hard to understand for us. So the intent of the question is that we want to know the whole picture.

joeljfischer commented 4 years ago

@Sohei-Suzuki @Shohei-Kawano

Could you tell us which Proposal?

This one https://github.com/smartdevicelink/sdl_evolution/blob/4061d5225528ee092652698ccc53479f54d097ce/proposals/0113-audiostreammanager.md

However, since Proposal is divided, the whole picture of the function that ScreenManager supports is hard to understand for us.

The general idea of the screen manager is to provide developers high-level APIs to perform UI operations and other basic functionality for their apps without the need to manually send / receive RPCs. The screen manager and its sub-managers can handle capabilities other other edge cases automatically for developers. The initial proposal is here. Many others have been made over the years to expand its functionality.

However, I believe that both of these questions are out of scope for this review.

Shohei-Kawano commented 4 years ago

Hi @joeljfischer -san

Thanks your comment.

We understand that AudioStreming has been proposed elsewhere. Thanks.

theresalech commented 4 years ago

The Steering Committee fully agreed to accept this proposal.

theresalech commented 4 years ago

Implementation issues entered: