search

smartdevicelink / sdl_hmi

BSD 3-Clause "New" or "Revised" License
14 stars 43 forks source link

HMI updates the choice list during active PerformInteraction(VR_ONLY) in case the second PI request is requested #650

Closed GetmanetsIrina closed 2 years ago

GetmanetsIrina commented 2 years ago

Precondition:

  1. SDL and HMI are started
  2. Mobile app is registered and activated
  3. 2 CreateInteractionChoiceSet is added with different

Steps to reproduce:

  1. Mobile app requests PerformInteraction(VR_ONLY) with the added 1st choice set
  2. Mobile app requests PerformInteraction(VR_ONLY) with the added 2nd choice set while the first one is in progress

Expected result:

HMI shows appropriate choices for the first request and rejects the second request

Actual result:

HMI updates the list of choices on the UI pop-up according to 2nd choice set while the first PI request is in progress

SDL -> HMI [15:35:44:26]: {"id":541,"jsonrpc":"2.0","method":"VR.PerformInteraction","params":{"appID":1675107234,"cancelID":0,"grammarID":[1982296165],"helpPrompt":[{"text":"Help prompt","type":"TEXT"}],"timeout":10000,"timeoutPrompt":[{"text":"Timeout prompt","type":"TEXT"}]}}

VRRPC.js:141 FFW.VR.onRPCRequest
VRRPC.js:421 FFW.VR.Started
RPCClient.js:323 HMI -> SDL [15:35:44:95]: {"jsonrpc":"2.0","method":"VR.Started"}
UIRPC.js:1562 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [15:35:44:101]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"VRSESSION","appID":1675107234}}
RPCClient.js:137 SDL -> HMI [15:35:44:124]: {"id":542,"jsonrpc":"2.0","method":"UI.PerformInteraction","params":{"appID":1675107234,"cancelID":0,"timeout":10000,"vrHelp":[{"position":1,"text":"ChoiceVR2"}],"vrHelpTitle":"Pick number:"}}

UIRPC.js:160 FFW.UI.onRPCRequest
UIRPC.js:1300 FFW.UI.UI.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [15:35:44:129]: {"jsonrpc":"2.0","id":542,"result":{"code":0,"method":"UI.PerformInteraction"}}
RPCClient.js:137 SDL -> HMI [15:35:47:539]: {"id":543,"jsonrpc":"2.0","method":"VR.PerformInteraction","params":{"appID":1675107234,"cancelID":0,"grammarID":[658020310],"helpPrompt":[{"text":"Help prompt","type":"TEXT"}],"timeout":10000,"timeoutPrompt":[{"text":"Timeout prompt","type":"TEXT"}]}}

VRRPC.js:141 FFW.VR.onRPCRequest
VRRPC.js:292 FFW.VR.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [15:35:47:540]: {"jsonrpc":"2.0","id":543,"error":{"code":4,"message":"VR.PerformInteraction is already in progress","data":{"method":"VR.PerformInteraction"}}}
RPCClient.js:137 SDL -> HMI [15:35:47:541]: {"id":544,"jsonrpc":"2.0","method":"UI.PerformInteraction","params":{"appID":1675107234,"cancelID":0,"timeout":10000,"vrHelp":[{"position":1,"text":"ChoiceVR1"}],"vrHelpTitle":"Pick number:"}}

UIRPC.js:160 FFW.UI.onRPCRequest
UIRPC.js:1300 FFW.UI.UI.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [15:35:47:544]: {"jsonrpc":"2.0","id":544,"result":{"code":0,"method":"UI.PerformInteraction"}}
RPCClient.js:137 SDL -> HMI [15:35:47:559]: {"id":545,"jsonrpc":"2.0","method":"UI.ClosePopUp","params":{"methodName":"UI.PerformInteraction"}}

UIRPC.js:160 FFW.UI.onRPCRequest
UIRPC.js:1159 FFW.UI.ClosePopUpResponse
RPCClient.js:323 HMI -> SDL [15:35:47:560]: {"jsonrpc":"2.0","id":545,"result":{"code":0,"method":"UI.ClosePopUp"}}
TTSRPC.js:456 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [15:35:52:37]: {"jsonrpc":"2.0","method":"TTS.Started"}
VRRPC.js:382 FFW.VR.VR.PerformInteractionResponse
VRRPC.js:292 FFW.VR.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [15:35:54:136]: {"jsonrpc":"2.0","id":541,"error":{"code":10,"message":"VR Perform Interaction error response.","data":{"method":"VR.PerformInteraction"}}}
RPCClient.js:137 SDL -> HMI [15:35:54:168]: {"id":546,"jsonrpc":"2.0","method":"UI.ClosePopUp","params":{"methodName":"UI.PerformInteraction"}}

UIRPC.js:160 FFW.UI.onRPCRequest
UIRPC.js:1159 FFW.UI.ClosePopUpResponse
RPCClient.js:323 HMI -> SDL [15:35:54:169]: {"jsonrpc":"2.0","id":546,"result":{"code":0,"method":"UI.ClosePopUp"}}
VRRPC.js:432 FFW.VR.Stopped
RPCClient.js:323 HMI -> SDL [15:35:54:171]: {"jsonrpc":"2.0","method":"VR.Stopped"}
UIRPC.js:1562 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [15:35:54:172]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"MAIN","appID":1675107234}}
TTSRPC.js:467 FFW.TTS.Stopped
RPCClient.js:323 HMI -> SDL [15:35:55:39]: {"jsonrpc":"2.0","method":"TTS.Stopped"}
GetmanetsIrina commented 2 years ago

Please notice Luxoft team is going to prepare a fix.

ShobhitAd commented 2 years ago

Closed via https://github.com/smartdevicelink/sdl_hmi/pull/656