smartdevicelink / sdl_hmi

BSD 3-Clause "New" or "Revised" License
14 stars 43 forks source link

Fix/hmi displays the value for tts+vr application language over the section name #660

Closed ValeriiMalkov closed 2 years ago

ValeriiMalkov commented 2 years ago

Implements/Fixes #657

This PR is ready for review.

Testing Plan

Manual testing

Summary

Fixed style for appTTSVRLang label

CLA

ValeriiMalkov commented 2 years ago

Hi @theresalech ! This PR is ready for livio team review!

ValeriiMalkov commented 2 years ago

Seems like it would be cleaner to just shorten the content of the label

  /*
   * Label with name of UILanguages select
   */
  appUILanguagesLabel: SDL.Label.extend({

    elementId: 'appUILanguagesLabel',

    classNames: 'appUILanguagesLabel',

-   content: 'application UI Languages'
+   content: 'App UI Languages'
  }
),

  /*
   * Label with name of TTSVRLanguages select
   */
  appTTSVRLanguagesLabel: SDL.Label.extend({

    elementId: 'appTTSVRLanguagesLabel',

    classNames: 'appTTSVRLanguagesLabel',

-   content: 'application (TTS + VR) Languages'
+   content: 'App (TTS + VR) Languages'
  }
),

@jacobkeeler Take a look changes in commit 44dc48e