search

smartdevicelink / sdl_hmi

BSD 3-Clause "New" or "Revised" License
14 stars 43 forks source link

HMI requests SDL.GetUserFriendlyMessage for removed policy group #672

Open GetmanetsIrina opened 2 years ago

GetmanetsIrina commented 2 years ago

Precondition:

  1. SDL is built with EXTERNAL_POLICY mode
  2. Policy server is started
  3. SDL is started
  4. HMI is started in external proprietary mode
  5. Mobile app is registered and activated
  6. Specific policy group with user consent (eg "Location-1") is assigned for the registered mobile app

Steps to reproduce:

  1. Remove policy group with user consent from the registered app on the policy server
  2. Perform PTU

Expected result:

HMI requests SDL.GetUserFriendlyMessage for the permissions according to SDL.OnAppPermissionChanged

Actual result:

HMI requests SDL.GetUserFriendlyMessage for the removed policy group and shows the message about the permissions from the not allowed group

BasicCommunicationRPC.js:1273 FFW.SDL.OnAppPermissionConsent
RPCClient.js:323 HMI -> SDL [14:13:4:300]: {"jsonrpc":"2.0","method":"SDL.OnAppPermissionConsent","params":{"source":"GUI","consentedFunctions":[{"name":"Location","id":156072572}],"appID":1767949347}}
BasicCommunicationRPC.js:943 SDL.UpdateSDL: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:126]: {"jsonrpc":"2.0","id":249,"method":"SDL.UpdateSDL","params":{}}
RPCClient.js:137 SDL -> HMI [14:13:7:158]: {"id":153,"jsonrpc":"2.0","method":"BasicCommunication.PolicyUpdate","params":{"file":"/tmp/fs/mp/images/ivsu_cache/sdl_snapshot.json","retry":[1,5,25,125,625],"timeout":60}}BasicCommunicationRPC.js:580 FFW.BasicCommunicationRPC.onRPCRequest
BasicCommunicationRPC.js:793 SDL.GetPolicyConfigurationData: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:160]: {"jsonrpc":"2.0","id":250,"method":"SDL.GetPolicyConfigurationData","params":{"policyType":"module_config","property":"endpoints"}}
BasicCommunicationRPC.js:1062 FFW.BC.BasicCommunication.PolicyUpdateResponse
RPCClient.js:323 HMI -> SDL [14:13:7:161]: {"jsonrpc":"2.0","id":153,"result":{"code":0,"method":"BasicCommunication.PolicyUpdate"}}
RPCClient.js:137 SDL -> HMI [14:13:7:161]: {"id":249,"jsonrpc":"2.0","result":{"code":0,"method":"SDL.UpdateSDL","result":"UPDATE_NEEDED"}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
RPCClient.js:137 SDL -> HMI [14:13:7:172]: {"id":250,"jsonrpc":"2.0","result":{"code":0,"method":"SDL.GetPolicyConfigurationData","value":["{\"0x04\":{\"default\":[\"http://localhost:3000/api/1/softwareUpdate\"]},\"0x07\":{\"default\":[\"https://policyserver.com:3001/api/v1/staging/policy\"]},\"lock_screen_icon_url\":{\"default\":[\"https://i.imgur.com/TgkvOIZ.png\"]},\"queryAppsUrl\":{\"default\":[\"http://localhost:3000/api/1/queryApps\"]}}"]}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
SettingsController.js:376 Next PTU iteration has been scheduled
SettingsController.js:392 Starting of PTU iteration
ExternalPolicies.js:105 Pack
ExternalPolicies.js:146 ExternalPolicies onWSMessage {"requestType": "PROPRIETARY", "data": "/tmp/fs/mp/images/ivsu_cache/sdl_snapshot.json"}
BasicCommunicationRPC.js:1491 FFW.BasicCommunication.OnSystemRequest
RPCClient.js:323 HMI -> SDL [14:13:7:175]: {"jsonrpc":"2.0","method":"BasicCommunication.OnSystemRequest","params":{"requestType":"PROPRIETARY","fileType":"JSON","timeout":1000,"fileName":"/tmp/fs/mp/images/ivsu_cache/sdl_snapshot.json","url":"https://policyserver.com:3001/api/v1/staging/policy"}}
RPCClient.js:137 SDL -> HMI [14:13:7:176]: {"jsonrpc":"2.0","method":"SDL.OnStatusUpdate","params":{"status":"UPDATING"}}BasicCommunicationRPC.js:421 FFW.BasicCommunicationRPC.onRPCNotification
BasicCommunicationRPC.js:893 SDL.GetUserFriendlyMessage: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:180]: {"jsonrpc":"2.0","id":251,"method":"SDL.GetUserFriendlyMessage","params":{"language":"EN-US","messageCodes":["StatusPending"]}}
RPCClient.js:137 SDL -> HMI [14:13:7:191]: {"id":251,"jsonrpc":"2.0","result":{"code":0,"messages":[{"line1":"Updating...","messageCode":"StatusPending","textBody":"Updating..."}],"method":"SDL.GetUserFriendlyMessage"}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
BasicCommunicationRPC.js:308 SDL.GetUserFriendlyMessage: Response from SDL!
RPCClient.js:137 SDL -> HMI [14:13:7:505]: {"id":154,"jsonrpc":"2.0","method":"BasicCommunication.SystemRequest","params":{"appID":1767949347,"fileName":"/tmp/fs/mp/images/ivsu_cache/12SYNC","requestType":"PROPRIETARY"}}BasicCommunicationRPC.js:580 FFW.BasicCommunicationRPC.onRPCRequest
ExternalPolicies.js:126 Unpack
BasicCommunicationRPC.js:1062 FFW.BC.BasicCommunication.SystemRequestResponse
RPCClient.js:323 HMI -> SDL [14:13:7:506]: {"jsonrpc":"2.0","id":154,"result":{"code":0,"method":"BasicCommunication.SystemRequest"}}
ExternalPolicies.js:159 ExternalPolicies onWSMessage {"requestType": "PROPRIETARY", "data": "/tmp/fs/mp/images/ivsu_cache/12SYNC"}
BasicCommunicationRPC.js:1254 FFW.SDL.OnReceivedPolicyUpdate
RPCClient.js:323 HMI -> SDL [14:13:7:509]: {"jsonrpc":"2.0","method":"SDL.OnReceivedPolicyUpdate","params":{"policyfile":"/tmp/fs/mp/images/ivsu_cache/12SYNC"}}
RPCClient.js:137 SDL -> HMI [14:13:7:554]: {"id":155,"jsonrpc":"2.0","method":"BasicCommunication.DecryptCertificate","params":{"fileName":"/home/igetmanets/sdl/builds/release_8_1/e/bin/storage/certificate"}}BasicCommunicationRPC.js:580 FFW.BasicCommunicationRPC.onRPCRequest
BasicCommunicationRPC.js:1062 FFW.BC.BasicCommunication.DecryptCertificateResponse
RPCClient.js:323 HMI -> SDL [14:13:7:554]: {"jsonrpc":"2.0","id":155,"result":{"code":0,"method":"BasicCommunication.DecryptCertificate"}}
RPCClient.js:137 SDL -> HMI [14:13:7:563]: {"jsonrpc":"2.0","method":"SDL.OnStatusUpdate","params":{"status":"UP_TO_DATE"}}BasicCommunicationRPC.js:421 FFW.BasicCommunicationRPC.onRPCNotification
BasicCommunicationRPC.js:793 SDL.GetPolicyConfigurationData: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:565]: {"jsonrpc":"2.0","id":252,"method":"SDL.GetPolicyConfigurationData","params":{"policyType":"module_config","property":"endpoint_properties"}}
BasicCommunicationRPC.js:893 SDL.GetUserFriendlyMessage: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:566]: {"jsonrpc":"2.0","id":253,"method":"SDL.GetUserFriendlyMessage","params":{"language":"EN-US","messageCodes":["StatusUpToDate"]}}
RPCClient.js:137 SDL -> HMI [14:13:7:576]: {"jsonrpc":"2.0","method":"SDL.OnAppPermissionChanged","params":{"appID":1767949347,"appRevokedPermissions":[{"id":156072572,"name":"Location"}],"isAppPermissionsRevoked":true,"priority":"NONE"}}BasicCommunicationRPC.js:421 FFW.BasicCommunicationRPC.onRPCNotification
BasicCommunicationRPC.js:893 SDL.GetUserFriendlyMessage: Request from HMI!
RPCClient.js:323 HMI -> SDL [14:13:7:576]: {"jsonrpc":"2.0","id":254,"method":"SDL.GetUserFriendlyMessage","params":{"language":"EN-US","messageCodes":["Location","AppPermissionsRevoked"]}}
RPCClient.js:137 SDL -> HMI [14:13:7:596]: {"id":156,"jsonrpc":"2.0","method":"VehicleInfo.GetVehicleData","params":{"odometer":true}}VehicleInfoRPC.js:136 FFW.VehicleInfo.onRPCRequest
VehicleInfoRPC.js:372 FFW.VehicleInfo.GetVehicleDataResponse
RPCClient.js:323 HMI -> SDL [14:13:7:597]: {"jsonrpc":"2.0","id":156,"result":{"odometer":23,"code":0,"method":"VehicleInfo.GetVehicleData"}}
RPCClient.js:137 SDL -> HMI [14:13:7:606]: {"id":252,"jsonrpc":"2.0","result":{"code":0,"method":"SDL.GetPolicyConfigurationData","value":["{}"]}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
RPCClient.js:137 SDL -> HMI [14:13:7:649]: {"id":253,"jsonrpc":"2.0","result":{"code":0,"messages":[{"line1":"Up-To-Date","messageCode":"StatusUpToDate","textBody":"Up-To-Date"}],"method":"SDL.GetUserFriendlyMessage"}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
BasicCommunicationRPC.js:308 SDL.GetUserFriendlyMessage: Response from SDL!
RPCClient.js:137 SDL -> HMI [14:13:7:650]: {"id":254,"jsonrpc":"2.0","result":{"code":0,"messages":[{"label":"GPS and speed","messageCode":"Location","textBody":"An app can access vehicle GPS and speed.","ttsString":"An app can access vehicle GPS and speed."},{"messageCode":"AppPermissionsRevoked","ttsString":"App authorizations have changed. %appName% can no longer access %functionalGroupLabels%. Please ensure you have the most recent app version installed on your mobile device."}],"method":"SDL.GetUserFriendlyMessage"}}BasicCommunicationRPC.js:225 FFW.BasicCommunicationRPC.onRPCResult
BasicCommunicationRPC.js:308 SDL.GetUserFriendlyMessage: Response from SDL!
TTSRPC.js:456 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [14:13:7:651]: {"jsonrpc":"2.0","method":"TTS.Started"}

OS & Version Information:

GetmanetsIrina commented 2 years ago

Please notice this is a non-regression issue. It's also reproduced on release 5.6.0