2093 - Soft button manager image upload fix

[joeljfischer]

Fixes #2093

Risk

This PR makes no API changes.

Testing Plan

• [x] I have verified that I have not introduced new warnings in this PR (or explain why below)
• [x] I have run the unit tests with this PR
• [x] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit test added for softButtonCapabilities.imageSupported = YES and displayCapabilities.graphicEnabled = NO, as well as visa-versa.

Core Tests

Tested that existing behavior continues to

Core version / branch / commit hash / module tested against: Sync 3.4 TDK (19353_DEVTEST) HMI name / version / branch / commit hash / module tested against: Sync 3.4 TDK (19353_DEVTEST)

Summary

This PR works around a bug when connecting to Sync 2.0 head units that causes the app to attempt to upload soft button images that will never work. This wastes bandwidth and time.

The issues happens because Sync 2.0 doesn't support softButtonCapabilities, so the library assumes all capabilities are available. However, Sync 2.0 does report that all graphics are unsupported in RAIR.displayCapabilities.graphicSupported.

Changelog

Bug Fixes

• Fixes attempted uploads of image data on SDL 2.0

Tasks Remaining:

n/a

CLA

• [x] I have signed the CLA

[codecov[bot]]

Codecov Report

Merging #2094 (f9fc42d) into develop (4580b82) will decrease coverage by 0.02%. The diff coverage is 75.00%.

:exclamation: Current head f9fc42d differs from pull request most recent head f62311c. Consider uploading reports for the commit f62311c to get more accurate results

@@             Coverage Diff             @@
##           develop    #2094      +/-   ##
===========================================
- Coverage    85.38%   85.35%   -0.03%     
===========================================
  Files          447      447              
  Lines        22598    22646      +48     
===========================================
+ Hits         19295    19330      +35     
- Misses        3303     3316      +13