smartdevicelink / sdl_ios

Get your app connected to the 🚙, make your users feel like a 🌟

www.smartdevicelink.com

BSD 3-Clause "New" or "Revised" License

169 stars 105 forks source link

Fix Release Script Bugs #2099

Closed Swift2568 closed 2 years ago

Swift2568 commented 2 years ago

Fixes #2098

Risk

This PR makes no API changes.

Testing Plan

[ ] I have verified that I have not introduced new warnings in this PR (or explain why below)
[ ] I have run the unit tests with this PR
[ ] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

N/A - release script only

Core Tests

N/A - release script only

Core version / branch / commit hash / module tested against: n/a HMI name / version / branch / commit hash / module tested against: n/a

Summary

Fixes a number of release script bugs identified during the June release.

Changelog

Bug Fixes

Added check before stash message
Fixed versions displaying flipped
"please update protocol versions" -> "please update versions"
Added commands to account for M1 architecture.
Fixed merge commands
Adjusted message for push/tag before Github page
Podspec edits should now stick (related to merge fix)
Adjusted logic around checkout of develop
Fixed Zip command

CLA

[x] I have signed the CLA

codecov[bot] commented 2 years ago

Codecov Report

Merging #2099 (416c27a) into develop (7324ff6) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 416c27a differs from pull request most recent head efd8789. Consider uploading reports for the commit efd8789 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2099   +/-   ##
========================================
  Coverage    85.33%   85.33%           
========================================
  Files          447      447           
  Lines        22646    22646           
========================================
  Hits         19326    19326           
  Misses        3320     3320