Closed jshivabeharry closed 1 year ago
Merging #2107 (34a43ef) into develop (aac94ee) will increase coverage by
0.11%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #2107 +/- ##
===========================================
+ Coverage 85.35% 85.47% +0.11%
===========================================
Files 447 448 +1
Lines 22651 22818 +167
===========================================
+ Hits 19334 19503 +169
+ Misses 3317 3315 -2
Fixes #1781
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Created two unit tests in
SDLTextAndGraphicManagerSpec
. One to test without batching if invidual operations are created and not cancelled. Another, to test the currentDataUpdatedHandler when given the error state.Core Tests
In manticore verified that properties in screen manager when set would not fail when one attribute was given bad data.
Core version / branch / commit hash / module tested against: sdl_core 8.1.0 (manticore) HMI name / version / branch / commit hash / module tested against: generic_hmi 0.12.0 (manticore)
Summary
SDLTextAndGraphicUpdateOperation
.sdl_updatePendingOperationsWithNewScreenData
update pending operations updated state property based on previously failed updates.currentScreenDataUpdatedHandler
.SDLTextAndGraphicUpdateOperation
add method to updated teh state with error data.Changelog
Enhancements
Bug Fixes
Tasks Remaining:
CLA