Apply fix to alert icon not uploading - Githubissues

smartdevicelink / sdl_javascript_suite

SmartDeviceLink library for applications developed in JavaScript

BSD 3-Clause "New" or "Revised" License

15 stars 13 forks source link

Apply fix to alert icon not uploading #561

Closed crokita closed 1 year ago

crokita commented 1 year ago

Fixes #558

Risk

This PR makes no API changes.

Testing Plan

[x] I have verified that I have not introduced new warnings in this PR (or explain why below)
[x] I have verified that this PR passes lint validation
[x] I have run the unit tests with this PR
[x] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Tests the Alert RPC generation when an AlertView has an icon

Summary

_PresentAlertOperation now keeps track of uploaded artwork names and uses it to check whether to attach the AlertView icon to the Alert RPC.

crokita commented 1 year ago

Note: artworksToBeUploaded line addition needs to filter out failed image uploads first before being used