search

smartdevicelink / sdl_requirements

Collection of requirements/technical tasks for new sdl_core features
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Descrepancy between HMI and MOBILE APIs for vehicle data structures #41

Open dboltovskyi opened 6 years ago

dboltovskyi commented 6 years ago

There is a discrepancy in HMI and MOBILE APIs for some vehicle data structures on optionality of parameters: E.g.: In GetVehicleData response there is a parameter "gps" with type "GPSData" In HMI API all parameters of GPSData structure are optional, but in MOBILE API all of them are mandatory. Currently SDL is unable to transfer response from HMI to Mobile application with some missing parameters of GPSData structure.

List of structures with differences:

Please clarify which API is correct?

KhrystynaDubovyk commented 6 years ago

@robinmk, please advise on the issue which API is correct

HMI API (are optional) MOBILE API (are mandatory)
GPSData GPSData
TireStatus TireStatus
BeltStatus BeltStatus
DeviceStatus DeviceStatus
AStasiuk commented 6 years ago

@robinmk, any updates on this question?

robinmk commented 6 years ago

I think they should be marked optional to not cause any compatibility issues. @JackLivio @mrapitis @yang1070 , thoughts?

mrapitis commented 6 years ago

These structs should probably have been originally made optional in the mobile api to allow the hmi to send data when its available. Moving forward I think we may need to deprecate the mandatory flags and resolve inconsistencies.

AStasiuk commented 6 years ago

@robinmk, @mrapitis so is it final decision to mark mentioned above parameters as an optional?

robinmk commented 6 years ago

We will bring this up as an item for discussion in the next SDLC meeting so that the entire SDLC is aware of the problem. Based on the feedback there we will plan our next steps.

AStasiuk commented 6 years ago

@robinmk, any updates regarding this issue?

AByzhynar commented 6 years ago

@robinmk Do we have any updates?

AByzhynar commented 6 years ago

@robinmk Please reply : do we have any updates related to this issue?

robinmk commented 6 years ago

No, there is no new updates on this. I will have to follow up on this.

KhrystynaDubovyk commented 4 years ago

the proposal aligning TireStatus API https://github.com/smartdevicelink/sdl_evolution/blob/da73ad1c298fd5cc3517c9e0a4a368974c0a4a57/proposals/0236-TireStatus-Mismatch.md