search

smartdevicelink / sdl_requirements

Collection of requirements/technical tasks for new sdl_core features
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

GetInteriorVehicleData(subscribe = false) by app unregistration #87

Closed GetmanetsIrina closed 6 years ago

GetmanetsIrina commented 6 years ago

Question is related to proposal https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0178-GetInteriorVehicleData.md.

Should SDL unsubscribe InteriorVehicleData with requests to HMI by app unregistration?

In case 'Yes' for 1st question - Should rules for InteriorVehicleData unsubscribtion be applied for app unregistration?

GetmanetsIrina commented 6 years ago

@KhrystynaDubovyk , @LuxoftAKutsan, please be informed about question.

yang1070 commented 6 years ago

@GetmanetsIrina, @KhrystynaDubovyk , @LuxoftAKutsan, That's a very good question. Thank you @GetmanetsIrina for catching this. The answer is Yes. SDL shall unsubscribe InteriorVehicleData if there is no applications subscribe to a module. app un-registration event and other events like lost connection, disable RC and maybe others, may cause the number of apps that subscribe to a module down to 0.

yang1070 commented 6 years ago

@GetmanetsIrina, Regarding the question Should rules for InteriorVehicleData unsubscribtion be applied for app unregistration?, what are the rules?

GetmanetsIrina commented 6 years ago

@yang1070 , rule is the the last app subscribed to module_1 is unregister SDL must send GetInteriorVD(subscribe=false), SDL will not send GetInteriorVD(subscribe=false) by app unregistration (has subscription for module_1) in case some other app is still has subscription for module_1.

yang1070 commented 6 years ago

@GetmanetsIrina, understood