search

smartdevicelink / sdl_requirements

Collection of requirements/technical tasks for new sdl_core features
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Should SDL set default values for DOP params? #94

Closed LitvinenkoIra closed 6 years ago

LitvinenkoIra commented 6 years ago

in proposal https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0175-Updating-DOP-value-range-for-GPS-notification.md

    <param name="pdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" since="X.Y">
        <description>PDOP.  If undefined or unavailable, then value shall be set to 0.</description>
    <history>
            <param name="pdop" type="Float" minvalue="0" maxvalue="10" defvalue="0" mandatory="true" until="X.Y">
            </param>
    </history>
    </param>
    <param name="hdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" since="X.Y">
        <description>HDOP.  If value is unknown, value shall be set to 0.</description>
    <history>
            <param name="hdop" type="Float" minvalue="0" maxvalue="10" defvalue="0" mandatory="true" until="X.Y">
            </param>
    </history>
    </param>
    <param name="vdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" since="X.Y">
        <description>VDOP.  If value is unknown, value shall be set to 0.</description>
    <history>
            <param name="vdop" type="Float" minvalue="0" maxvalue="10" defvalue="0" mandatory="true" until="X.Y">
            </param>
    </history>
    </param>

Should SDL set the values of pdop, hdop and vdop to 0 if these params are not mandatory?

LitvinenkoIra commented 6 years ago

@atiwari9 please be informed about question

atiwari9 commented 6 years ago

@LitvinenkoIra - Since pdop/vdop/hdop are non-mandatory, SDL should exclude these params if these are not included by HMI

LitvinenkoIra commented 6 years ago

@atiwari9 than I think that description should be updated <description>HDOP. If value is unknown, value shall be set to 0.</description> to <description>HDOP. </description>

LitvinenkoIra commented 6 years ago

Also we don't have "history" mechanism in open source SDL. So if we just add 

  <param name="pdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" since="X.Y">
    <description>PDOP.</description>
    <history>
      <param name="pdop" type="Float" minvalue="0" maxvalue="10" defvalue="0" mandatory="true" until="X.Y">
      </param>
    </history>
  </param>

to API, SDL cannot parse "since" and "untill" fields. We need to update generating interface source code in case if we want to add this params. But I think that we don't need those params at all if this feature will be included to 5.0 release. @yang1070 What do you think about it?

LitvinenkoIra commented 6 years ago

I propose making the following changes in API in scope of this proposal:

    <param name="pdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false">
        <description>PDOP.</description>
    </param>
    <param name="hdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" >
        <description>HDOP.</description>
    </param>
    <param name="vdop" type="Float" minvalue="0" maxvalue="1000" mandatory="false" >
        <description>VDOP.</description>
    </param>
atiwari9 commented 6 years ago

@LitvinenkoIra - We'd need to keep the history and since fields. I'd recommend that interface generator should be updated to parse these fields.

For Description, we'd need to update that and we'll log a bug to do so. Can you please implement it such a way that SDL excludes VDOP/PDOP/HDOP if these are not included by HMI

LitvinenkoIra commented 6 years ago

@atiwari9

Ok, we will update the interface generator and implement the described behavior.