Fix CI testing - Githubissues

smartfile / client-python

SmartFile API Client (Python).

http://app.smartfile.com/api/

MIT License

20 stars 7 forks source link

Fix CI testing #15

Closed cabarnes closed 7 years ago

cabarnes commented 7 years ago

Previously, the tests weren't even being run. This is because a directory named test was added and the Makefile target test was not PHONY. Once the tests were being run, there was an incompatibility with the string encoding that needed to be resolved for tests to pass.

coveralls commented 7 years ago

Coverage remained the same at 71.193% when pulling 968dc9d8f6a398d9703a40cdb9f6f77045e79d9e on fix-testing into ac8194608546678b584fc9b82bb707017075f0d4 on master.

coveralls commented 7 years ago

Coverage remained the same at 71.193% when pulling 5080b5a6ac3adfac18f9800a7093d8f03a153d5f on fix-testing into ac8194608546678b584fc9b82bb707017075f0d4 on master.

btimby commented 7 years ago

LGTM. Nice job Clif.